felipecrv commented on code in PR #44190:
URL: https://github.com/apache/arrow/pull/44190#discussion_r1771587961
##########
cpp/src/arrow/array/array_binary.cc:
##########
@@ -125,12 +125,8 @@ FixedSizeBinaryArray::FixedSizeBinaryArray(const
std::shared_ptr<DataType>& type
int64_t length,
const std::shared_ptr<Buffer>& data,
const std::shared_ptr<Buffer>&
null_bitmap,
- int64_t null_count, int64_t offset)
- : PrimitiveArray(type, length, data, null_bitmap, null_count, offset),
- byte_width_(checked_cast<const
FixedSizeBinaryType&>(*type).byte_width()) {}
Review Comment:
This constructor simplification looks like it removed important things. (?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
