zanmato1984 commented on PR #44236: URL: https://github.com/apache/arrow/pull/44236#issuecomment-2376441727
> So they would not get error in these scenrio? The errors touched in this PR are all internal invariants, that are not breakable by user inputs. In other words, these errors can only occur on bad implementation, so `DCHECK` should be sufficient. As a comparison, some checking, e.g. https://github.com/apache/arrow/blob/80622fa077e5232037cde10e222fca4004ad9d0c/cpp/src/arrow/compute/row/grouper.cc#L65-L68 can be triggered by user's (invalid) input, so it is kept as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
