etseidl commented on code in PR #6466:
URL: https://github.com/apache/arrow-rs/pull/6466#discussion_r1778975670
##########
parquet/src/file/serialized_reader.rs:
##########
@@ -204,41 +206,30 @@ impl<R: 'static + ChunkReader> SerializedFileReader<R> {
}
}
if keep {
- filtered_row_groups.push(rg_meta);
+ metadata_builder = metadata_builder.add_row_group(rg_meta);
}
}
if options.enable_page_index {
let mut columns_indexes = vec![];
let mut offset_indexes = vec![];
- for rg in &mut filtered_row_groups {
+ for rg in metadata_builder.row_groups().iter() {
Review Comment:
```rust
if options.enable_page_index {
let mut reader =
ParquetMetaDataReader::new_with_metadata(metadata_builder.build())
.with_page_indexes(options.enable_page_index);
reader.read_page_indexes(&chunk_reader)?;
metadata_builder =
ParquetMetaDataBuilder::new_from_metadata(reader.finish()?);
}
```
I forgot to do this in #6450.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
