WillAyd commented on code in PR #2234:
URL: https://github.com/apache/arrow-adbc/pull/2234#discussion_r1792518010
##########
c/validation/adbc_validation_statement.cc:
##########
@@ -263,6 +267,11 @@ void StatementTest::TestSqlIngestLargeString() {
NANOARROW_TYPE_LARGE_STRING, {std::nullopt, "", "", "1234", "例"},
false));
}
+void StatementTest::TestSqlIngestStringView() {
+ ASSERT_NO_FATAL_FAILURE(TestSqlIngestType<std::string>(
+ NANOARROW_TYPE_STRING_VIEW, {std::nullopt, "", "", "1234", "例"}, false));
Review Comment:
Not sure how much this affects the test suite, but probably good to add a
string here that will exceed the inline size (maybe even as a separate test)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
