ripplehang commented on code in PR #43601:
URL: https://github.com/apache/arrow/pull/43601#discussion_r1793491320
##########
cpp/src/arrow/filesystem/s3fs_benchmark.cc:
##########
@@ -81,7 +81,12 @@ class MinioFixture : public benchmark::Fixture {
}
client_config_.endpointOverride = ToAwsString(minio_->connect_string());
- client_config_.scheme = Aws::Http::Scheme::HTTP;
+ if (minio_->scheme() == "https") {
Review Comment:
would the benchmark be run on both windows and linux?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
