nealrichardson opened a new pull request #9689: URL: https://github.com/apache/arrow/pull/9689
Without the ARROW_R_WITH_ARROW wrapping around the code in arrowExports.cpp, if Arrow C++ is not available, the build fails--as expected. However, it does so with on the order of 10,000 lines of compiler errors because all 400 function definitions in that file fail to compile. For 4.0, given that CRAN is running Solaris checks again, we need to not fail anymore. We could just restore the previous wrapping of every function, but I wanted to try something lighter weight. Going forward, once we decide that ARROW_R_WITH_ARROW must always be true, we should fail earlier and clearer, maybe in `configure` if possible, so that the user's terminal doesn't blow up and so they can see what the actual problem is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
