paleolimbot commented on code in PR #644:
URL: https://github.com/apache/arrow-nanoarrow/pull/644#discussion_r1819283728
##########
.github/workflows/python-wheels.yaml:
##########
@@ -107,9 +109,16 @@ jobs:
fetch-tags: true
- uses: actions/setup-python@v5
+ if: ${{ matrix.config.label != "windows" }}
Review Comment:
```suggestion
if: ${{ matrix.config.label != 'windows' }}
```
##########
.github/workflows/python-wheels.yaml:
##########
@@ -107,9 +109,16 @@ jobs:
fetch-tags: true
- uses: actions/setup-python@v5
+ if: ${{ matrix.config.label != "windows" }}
with:
python-version: "3.12"
+ - uses: actions/setup-python@v5
+ if: ${{ matrix.config.label == "windows" }}
Review Comment:
```suggestion
if: ${{ matrix.config.label == 'windows' }}
```
...perhaps why the wheels CI job isn't buildings:
```
The workflow is not valid. .github/workflows/python-wheels.yaml (Line: 112,
Col: 13): Unexpected symbol: '"windows"'. Located at position 24 within
expression: matrix.config.label != "windows"
.github/workflows/python-wheels.yaml (Line: 117, Col: 13): Unexpected symbol:
'"windows"'. Located at position 24 within expression: matrix.config.label ==
"windows"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
