felipecrv commented on code in PR #44394:
URL: https://github.com/apache/arrow/pull/44394#discussion_r1824534201
##########
cpp/src/arrow/compute/api_vector.cc:
##########
@@ -155,6 +155,11 @@ static auto kPairwiseOptionsType =
GetFunctionOptionsType<PairwiseOptions>(
DataMember("periods", &PairwiseOptions::periods));
static auto kListFlattenOptionsType =
GetFunctionOptionsType<ListFlattenOptions>(
DataMember("recursive", &ListFlattenOptions::recursive));
+static auto kReverseIndicesOptionsType =
GetFunctionOptionsType<ReverseIndicesOptions>(
+ DataMember("output_length", &ReverseIndicesOptions::output_length),
+ DataMember("output_type", &ReverseIndicesOptions::output_type));
+static auto kPermuteOptionsType = GetFunctionOptionsType<PermuteOptions>(
+ DataMember("output_length", &PermuteOptions::output_length));
Review Comment:
As a category, these are usually called scatter-gather, permute [1], or
shuffle. I would probably go with `vector_permute.cc` here.
In the Intel manual, these operations are types of "permute" under the
broader category called "Swizzle" [1]. We could call it `vector_swizzle.cc` and
have the option to expand the implemented operations in the future.
[1]
https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#cats=Swizzle&text=permute
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
