birschick-bq commented on code in PR #2296:
URL: https://github.com/apache/arrow-adbc/pull/2296#discussion_r1826123907
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Reader.cs:
##########
@@ -178,6 +189,18 @@ internal static Date32Array ConvertToDate32(StringArray
array, IArrowType _)
return resultArray.Build();
}
+ internal static FloatArray ConvertToFloat(DoubleArray array,
IArrowType _)
+ {
+ var resultArray = new FloatArray.Builder();
+ int length = array.Length;
Review Comment:
Added call to .Reserve() for all array builders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
