tustvold commented on code in PR #6662:
URL: https://github.com/apache/arrow-rs/pull/6662#discussion_r1826175583
##########
arrow-string/src/predicate.rs:
##########
@@ -116,10 +116,17 @@ impl<'a> Predicate<'a> {
}),
Predicate::Contains(finder) => {
if let Some(string_view_array) =
array.as_any().downcast_ref::<StringViewArray>() {
+ let nulls = string_view_array.logical_nulls();
BooleanArray::from(
string_view_array
.bytes_iter()
- .map(|haystack| finder.find(haystack).is_some() !=
negate)
+ .enumerate()
+ .map(|(idx, haystack)| {
+ if nulls.as_ref().map(|n|
n.is_null(idx)).unwrap_or_default() {
Review Comment:
FWIW I am not sure why this isn't using from_unary like the other codepaths
which would provide option 2, and be significantly more efficient than first
collecting into a Vec...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
