austin362667 commented on code in PR #6671:
URL: https://github.com/apache/arrow-rs/pull/6671#discussion_r1826861129
##########
arrow-string/src/length.rs:
##########
@@ -115,6 +116,8 @@ pub fn length(array: &dyn Array) -> Result<ArrayRef,
ArrowError> {
/// * bit_length of null is null.
/// * bit_length is in number of bits
pub fn bit_length(array: &dyn Array) -> Result<ArrayRef, ArrowError> {
+ println!("In Array bit_length()");
Review Comment:
removed, sorry for such mistake..
##########
arrow-string/src/length.rs:
##########
@@ -137,6 +140,26 @@ pub fn bit_length(array: &dyn Array) -> Result<ArrayRef,
ArrowError> {
let list = array.as_string::<i64>();
Ok(bit_length_impl::<Int64Type>(list.offsets(), list.nulls()))
}
+ DataType::Utf8View => {
+ let list = array.as_string_view();
+ let values = list
+ .views()
+ .iter()
+ .enumerate()
+ .map(|(i, _)| {
Review Comment:
of course, sorry for such mistake..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
