tustvold commented on code in PR #6698:
URL: https://github.com/apache/arrow-rs/pull/6698#discussion_r1834550615
##########
object_store/src/aws/client.rs:
##########
@@ -350,7 +350,7 @@ impl<'a> Request<'a> {
}
pub(crate) fn with_payload(mut self, payload: PutPayload) -> Self {
- if !self.config.skip_signature || self.config.checksum.is_some() {
+ if self.config.sign_payload || self.config.checksum.is_some() {
Review Comment:
```suggestion
if (!self.config.skip_signature && self.config.sign_payload) ||
self.config.checksum.is_some() {
```
We shouldn't compute the checksum if request signing is completely disabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
