nealrichardson commented on a change in pull request #9717:
URL: https://github.com/apache/arrow/pull/9717#discussion_r594743736
##########
File path: r/R/dplyr.R
##########
@@ -264,17 +264,24 @@ arrow_eval <- function (expr, mask) {
# else, for things not supported by Arrow return a "try-error",
# which we'll handle differently
msg <- conditionMessage(e)
- # TODO(ARROW-11700): internationalization
- if (grepl("object '.*'.not.found", msg)) {
- stop(e)
- }
- if (grepl('could not find function ".*"', msg)) {
+ patterns <- paste(i18ize_error_messages(), collapse = "|")
Review comment:
I want to move this to something that is evaluated once instead of every
time we evaluate an expression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
