pitrou commented on a change in pull request #9643:
URL: https://github.com/apache/arrow/pull/9643#discussion_r595148295



##########
File path: cpp/src/arrow/util/type_fwd.h
##########
@@ -17,14 +17,14 @@
 
 #pragma once
 
+#include <functional>
+
 namespace arrow {
 
 namespace detail {
 struct Empty;
-}  // namespace detail
+}
 
-template <typename T = detail::Empty>
-class Future;

Review comment:
       Just my 2 cents, but for readability it seems better not to dump 
everything in a single header.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to