nealrichardson commented on code in PR #44652:
URL: https://github.com/apache/arrow/pull/44652#discussion_r1843767129
##########
r/tests/testthat/test-dplyr-distinct.R:
##########
@@ -115,12 +103,57 @@ test_that("across() works in distinct()", {
})
test_that("distinct() can return all columns", {
- skip("ARROW-14045")
- compare_dplyr_binding(
- .input %>%
- distinct(lgl, .keep_all = TRUE) %>%
- collect() %>%
- arrange(int),
- tbl
- )
+ # hash_one prefers to keep non-null values, which is different from
.keep_all in dplyr
+ # so we can't compare the result directly
+ expected <- tbl %>%
+ # Drop factor because of #44661:
+ # NotImplemented: Function 'hash_one' has no kernel matching input types
+ # (dictionary<values=string, indices=int8, ordered=0>, uint8)
Review Comment:
Yeah that's the error message. I'd have to think about how/where best to
catch that and translate that to R-speak. As it turns out, dictionary isn't the
only unsupported type, it's just the only one we have in this test data frame.
I think list types and other non-simple types are also not supported, IIRC from
RTFS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
