zeroshade commented on a change in pull request #9671:
URL: https://github.com/apache/arrow/pull/9671#discussion_r595170378
##########
File path: go/parquet/internal/bmi/_lib/bitmap_bmi2.s
##########
@@ -0,0 +1,174 @@
+ .text
Review comment:
technically the assembly in this directory isn't necessary to be checked
in and could be left out, only the assembly in the directory above this needs
to be checked in. I checked this assembly in to follow the pattern that is in
the arrow Go module, but have no problem removing this assembly as the Makefile
provides the ability to re-generate them easily. @sbinet thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
