pitrou commented on code in PR #44497:
URL: https://github.com/apache/arrow/pull/44497#discussion_r1846650678


##########
python/pyarrow/tests/test_table.py:
##########
@@ -2301,6 +2301,10 @@ def test_table_from_pydict(cls):
     with pytest.raises(TypeError):
         cls.from_pydict({'a': [1, 2, 3]}, schema={})
 
+    # With dicts containing NaNs

Review Comment:
   This test isn't related to `from_pydict`, we should either make it a purely 
C++ test as @kou suggested, or add it to an equality related test case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to