tustvold commented on code in PR #6738:
URL: https://github.com/apache/arrow-rs/pull/6738#discussion_r1847901291
##########
parquet/src/thrift.rs:
##########
@@ -96,13 +106,22 @@ impl<'a> TCompactSliceInputProtocol<'a> {
}
}
+macro_rules! thrift_unimplemented {
+ () => {
+ Err(thrift::Error::Protocol(thrift::ProtocolError {
+ kind: thrift::ProtocolErrorKind::NotImplemented,
+ message: "not implemented".to_string(),
+ }))
+ };
+}
+
impl TInputProtocol for TCompactSliceInputProtocol<'_> {
fn read_message_begin(&mut self) -> thrift::Result<TMessageIdentifier> {
- unimplemented!()
+ thrift_unimplemented!()
Review Comment:
No it is actually genuinely unreachable, we don't use thrift messages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
