tustvold commented on code in PR #6682:
URL: https://github.com/apache/arrow-rs/pull/6682#discussion_r1857458086


##########
object_store/src/aws/precondition.rs:
##########
@@ -118,6 +138,17 @@ pub enum S3ConditionalPut {
     /// [HTTP precondition]: 
https://datatracker.ietf.org/doc/html/rfc9110#name-preconditions
     ETagMatch,
 
+    /// Like `ETagMatch`, but with support for `PutMode::Create` and not
+    /// `PutMode::Option`.
+    ///
+    /// This is the limited form of conditional put supported by Amazon S3
+    /// as of August 2024 ([announcement]).
+    ///
+    /// Encoded as `etag-put-if-not-exists` ignoring whitespace.
+    ///
+    /// [announcement]: 
https://aws.amazon.com/about-aws/whats-new/2024/08/amazon-s3-conditional-writes/
+    ETagPutIfNotExists,

Review Comment:
   S3 now supports the full header so I wonder if we need this anymore?
   
   https://github.com/apache/arrow-rs/issues/6799



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to