emilk commented on code in PR #6790:
URL: https://github.com/apache/arrow-rs/pull/6790#discussion_r1858295068
##########
arrow/tests/shrink_to_fit.rs:
##########
@@ -0,0 +1,142 @@
+use arrow::{
+ array::{Array, ArrayRef, ListArray, PrimitiveArray},
+ buffer::OffsetBuffer,
+ datatypes::{Field, UInt8Type},
+};
+
+/// Test that `shrink_to_fit` frees memory after concatenating a large number
of arrays.
+#[test]
+fn test_shrink_to_fit_after_concat() {
+ let array_len = 6_000;
+ let num_concats = 100;
+
+ let primitive_array: PrimitiveArray<UInt8Type> = (0..array_len)
+ .map(|v| (v % 255) as u8)
+ .collect::<Vec<_>>()
+ .into();
+ let primitive_array: ArrayRef = Arc::new(primitive_array);
+
+ let list_array: ArrayRef = Arc::new(ListArray::new(
+ Field::new_list_field(primitive_array.data_type().clone(),
false).into(),
+ OffsetBuffer::from_lengths([primitive_array.len()]),
+ primitive_array.clone(),
+ None,
+ ));
+
+ // Num bytes allocated globally and by this thread, respectively.
+ let (concatenated, _bytes_allocated_globally,
bytes_allocated_by_this_thread) =
+ memory_use(|| {
+ let mut concatenated = concatenate(num_concats,
list_array.clone());
+ concatenated.shrink_to_fit(); // This is what we're testing!
Review Comment:
Without this call, this test fails (as it should).
In other words, this test is a regression-test for `shrink_to_fit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
