amol- commented on PR #44447:
URL: https://github.com/apache/arrow/pull/44447#issuecomment-2513141273
I think the two failures are unrelated to this branch.
For Java it seems to be a memory leak in FlightSQL
```
Error: TestFlightSqlStreams.tearDown:238 » IllegalState Memory was leaked
by query. Memory leaked: (81920)
```
And for R it seems related to datetimes
```
── Failure ('test-dplyr-funcs-datetime.R:302:5'): timestamp round trip
correctly via strftime and strptime ──
```
This pull request introduces a new feature for creating boolean mask arrays
in the Arrow library and includes corresponding tests and documentation
updates. The most important changes are summarized below:
### New Feature: Boolean Mask Arrays
*
[`cpp/src/arrow/array/util.cc`](diffhunk://#diff-c3b0484ad8586ff46fa035d446a7d1c3a30cd35d13cd05678c99814938e07d5bR920-R984):
Added `MakeMaskArray` functions to create boolean mask arrays from either a
vector of indices or an Arrow array of indices. These functions set specified
indices to true and all other indices to false.
*
[`cpp/src/arrow/array/array_test.cc`](diffhunk://#diff-0d86cf45e6dbc2db7c716f28ac6f7c6a1d938f5dc91611a2394f8b250c178026R897-R917):
Added a new test case `TestMakeMaskArray` to verify the correctness of the
`MakeMaskArray` functions, including tests for out-of-bounds indices.
### Header and Implementation Updates
*
[`cpp/src/arrow/array/util.h`](diffhunk://#diff-61040a2cf5bfc48c4e7edf5b64494ca173a471c6ca1e4e318270e99366015163R72-R98):
Declared the `MakeMaskArray` functions with detailed documentation on their
usage and parameters.
*
[`cpp/src/arrow/array/util.cc`](diffhunk://#diff-c3b0484ad8586ff46fa035d446a7d1c3a30cd35d13cd05678c99814938e07d5bR32):
Included necessary headers and using declarations for the new functions.
[[1]](diffhunk://#diff-c3b0484ad8586ff46fa035d446a7d1c3a30cd35d13cd05678c99814938e07d5bR32)
[[2]](diffhunk://#diff-c3b0484ad8586ff46fa035d446a7d1c3a30cd35d13cd05678c99814938e07d5bR55)
### Python Bindings and Tests
*
[`python/pyarrow/array.pxi`](diffhunk://#diff-8511a20d3b6b9b098c1ac0dfc286e8127fdc60f96172adac4d281697527db8c2R541-R585):
Added a `mask` function to create a boolean mask array in Python using the new
`MakeMaskArray` functionality.
*
[`python/pyarrow/tests/test_array.py`](diffhunk://#diff-626a9af939cc3db72d09d8db062e114297ac25b45f9057f864191a98c40e2d34R4231-R4239):
Added a test case `test_mask_array` to verify the Python `mask` function.
### Documentation
*
[`docs/source/python/api/arrays.rst`](diffhunk://#diff-47cf574ae5cbb4ec39df97e7472728aba21c60c8d0c39cfb4f80dcc7e05cf128R34):
Updated the documentation to include the new `mask` function.
*
[`python/pyarrow/__init__.py`](diffhunk://#diff-d4875eaed78803ab6f81979ac5cdc15bf0cc756d94fd12ef1a3d61bea2fe773bL196-R196):
Added `mask` to the list of imported functions in the `pyarrow` module.
*
[`python/pyarrow/includes/libarrow.pxd`](diffhunk://#diff-48e87fef366d65330100bf1703a542b8cb447575b6f8c3a3617741ce57854d4aR249-R254):
Declared the `MakeMaskArray` functions in the Cython header file for Arrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
