wgtmac commented on code in PR #44921:
URL: https://github.com/apache/arrow/pull/44921#discussion_r1868672995
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1301,6 +1301,10 @@ class TypedColumnWriterImpl : public ColumnWriterImpl,
public TypedColumnWriter<
bool single_nullable_element =
(level_info_.def_level == level_info_.repeated_ancestor_def_level + 1)
&&
leaf_field_nullable;
+ if (!leaf_field_nullable && leaf_array.null_count() != 0) {
Review Comment:
Yes in most cases. I remember that when I did the trick to make mutable (and
reusable) arrays. An empty ArrayData is first created by calling
`std::shared_ptr<ArrayData> ArrayData::Make(std::shared_ptr<DataType> type,
int64_t length, int64_t null_count, int64_t offset)` with default values and
then set it to array via `void Array::SetData(const std::shared_ptr<ArrayData>&
data)`. The null_count is -1 if not manually maintained.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
