tustvold commented on code in PR #6794:
URL: https://github.com/apache/arrow-rs/pull/6794#discussion_r1874762133
##########
object_store/src/client/s3.rs:
##########
@@ -106,14 +106,32 @@ pub(crate) struct CompleteMultipartUpload {
pub part: Vec<MultipartPart>,
}
+#[derive(Serialize, Deserialize)]
+pub(crate) struct PartMetadata {
+ pub e_tag: String,
+ #[serde(skip_serializing_if = "Option::is_none")]
+ pub checksum: Option<String>,
Review Comment:
```suggestion
pub checksum_sha256: Option<String>,
```
##########
object_store/src/aws/client.rs:
##########
@@ -617,8 +617,15 @@ impl S3Client {
location: &Path,
opts: PutMultipartOpts,
) -> Result<MultipartId> {
- let response = self
- .request(Method::POST, location)
+ let mut reqquest = self.request(Method::POST, location);
Review Comment:
```suggestion
let mut request = self.request(Method::POST, location);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
