jonkeane commented on code in PR #44971:
URL: https://github.com/apache/arrow/pull/44971#discussion_r1878796052
##########
r/R/arrow-datum.R:
##########
@@ -139,17 +140,16 @@ Math.ArrowDatum <- function(x, ..., base = exp(1), digits
= 0) {
cumprod = eval_array_expression("cumulative_prod_checked", x),
cummax = eval_array_expression("cumulative_max", x),
cummin = eval_array_expression("cumulative_min", x),
+ cosh = eval_array_expression("cosh", x),
+ sinh = eval_array_expression("sinh", x),
+ tanh = eval_array_expression("tanh", x),
+ acosh = eval_array_expression("acosh_checked", x),
+ asinh = eval_array_expression("asinh", x),
+ atanh = eval_array_expression("atanh_checked", x),
Review Comment:
Mostly out of curiosity: did we miss these earlier? Or are they also new?
##########
r/NEWS.md:
##########
@@ -19,6 +19,10 @@
# arrow 18.1.0.9000
+- Added missing dplyr binding for atan (#44953)
+- Added bindings for hyperbolig trig functions sinh, cosh, tanh, asinh, acosh,
and tanh (#44953)
+- Added bindings for expm1 (#44953)
Review Comment:
It doesn't _really_ matter but I wonder if collapsing these into one bullet
(since there's one issue) would be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
