nealrichardson commented on PR #44989:
URL: https://github.com/apache/arrow/pull/44989#issuecomment-2536163137
> > The error case should probably `return("0")`
>
> It would probably be more forward-looking to avoid the error entirely. Why
does the function fail parsing the CMake version? Can we add `cmake --version`
somewhere in the GH workflow?
I could be remembering wrong, but I believe the function is used to check
for cmake of a certain version, and this is to be robust to where cmake may not
be installed or not found at the path provided. It does not emit an error, it
traps it.
This might not be where the error is coming from that was observed in CI, I
was just browsing the source to see where you might get a numeric version
error. Looking again, and reading the output it produced, I think we're hitting
this:
https://github.com/apache/arrow/pull/44989/files#diff-935746c34b16289a07b0d9bf7642dbd268b18059b6187f7cdec7c464be47a3deL718
```
} else {
# Keep trying
lg("Not using cmake found at %s", path, .indent = "****")
if (found_version > 0) {
lg("Version >= %s required; found %s", version_required,
found_version, .indent = "*****")
} else {
```
should be `found_version > "0"`. We must not have been running into this
before because the "found_version" was always sufficient if found, and if it
wasn't found, we were returning a numeric `0` which works in this comparison.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
