ianmcook commented on a change in pull request #9745:
URL: https://github.com/apache/arrow/pull/9745#discussion_r597966525
##########
File path: r/R/array.R
##########
@@ -131,6 +133,12 @@ Array <- R6Class("Array",
assert_is(i, "Array")
call_function("filter", self, i, options = list(keep_na = keep_na))
},
+ SortIndices = function(descending = FALSE) {
Review comment:
I think if `Take` and `Filter` are R6 methods, then it makes sense for
`SortIndices` to be an R6 method. In the C++ compute API, these three functions
are all defined in the same way (see
[`cpp/src/arrow/compute/api_vector.h`](https://github.com/apache/arrow/blob/master/cpp/src/arrow/compute/api_vector.h)).
My preference would be to keep it as an R6 method and create a separate
`order_arrow` function the behaves like `order()` if we want that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
