alamb commented on issue #6737: URL: https://github.com/apache/arrow-rs/issues/6737#issuecomment-2549626308
> It seems there is potentially an overall project question of when is using a panic desired and what efforts should be made to clean up existing code with this standard? Yes I think having clear guidelines on when to panic (basically an uncatchable panic) vs return errors would be helpful I think there is a tension between the decreased usability of APIs that require handling / propagating errors and allowing errors to propagate. In my opinion, if an API returns an error, it is an error that some program might want to catch. If the only errors that can be returned are due to bugs in code (aka internals errors) it is less clear to me an error is appropriate in that case For invalid inputs beyond the control of the calling program (e.g. invalid parquet files) i think returning errors rather than panic is a very reasonable behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
