pitrou commented on code in PR #35323:
URL: https://github.com/apache/arrow/pull/35323#discussion_r1890481417
##########
ci/scripts/python_wheel_windows_build.bat:
##########
@@ -121,7 +121,13 @@ set ARROW_HOME=C:\arrow-dist
set CMAKE_PREFIX_PATH=C:\arrow-dist
pushd C:\arrow\python
-@REM bundle the msvc runtime
-cp "C:\Program Files (x86)\Microsoft Visual
Studio\2017\Community\VC\Redist\MSVC\14.16.27012\x64\Microsoft.VC141.CRT\msvcp140.dll"
pyarrow\
+@REM build wheel
python setup.py bdist_wheel || exit /B 1
+
+@REM Repair the wheel with delvewheel
+pip install delvewheel || exit /B 1
+for /f %%i in ('dir dist\pyarrow-*.whl /B') do set WHEEL_NAME=dist\%%i || exit
/B 1
+echo "Wheel name: %WHEEL_NAME%"
+delvewheel repair %WHEEL_NAME% --add-path
C:\arrow\python\build\bdist.win-amd64\wheel\pyarrow -w repaired_wheels || exit
/B 1
Review Comment:
Is the `--add-path` actually necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
