zxf commented on a change in pull request #9744: URL: https://github.com/apache/arrow/pull/9744#discussion_r598270779
########## File path: java/adapter/jdbc/src/test/java/org/apache/arrow/adapter/jdbc/consumer/BinaryConsumerTest.java ########## @@ -0,0 +1,116 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.arrow.adapter.jdbc.consumer; + +import static org.junit.Assert.*; + +import java.io.ByteArrayInputStream; +import java.io.IOException; +import java.util.function.Consumer; + +import org.apache.arrow.vector.BaseValueVector; +import org.apache.arrow.vector.VarBinaryVector; +import org.junit.Test; + +public class BinaryConsumerTest extends AbstractConsumerTest { + + private static final int INITIAL_VALUE_ALLOCATION = BaseValueVector.INITIAL_VALUE_ALLOCATION; + private static final int DEFAULT_RECORD_BYTE_COUNT = 8; + + protected void assertConsume(boolean nullable, Consumer<BinaryConsumer> dataConsumer, byte[][] expect) { + try (final VarBinaryVector vector = new VarBinaryVector("binary", allocator)) { + BinaryConsumer consumer = BinaryConsumer.createConsumer(vector, 0, nullable); + dataConsumer.accept(consumer); + assertEquals(expect.length - 1, vector.getLastSet()); + for (int i = 0; i < expect.length; i++) { + byte[] value = expect[i]; + if (value == null) { + assertTrue(vector.isNull(i)); + } else { + assertArrayEquals(expect[i], vector.get(i)); + } + } + } + } + + private byte[] createBytes(int length) { + byte[] bytes = new byte[length]; + for (int i = 0; i < length; i++) { + bytes[i] = (byte) (i % 1024); + } + return bytes; + } + + + public void testConsumeInputStream(byte[][] values, boolean nullable) throws IOException { + assertConsume(nullable, binaryConsumer -> { + for (byte[] value : values) { + try { + binaryConsumer.consume(new ByteArrayInputStream(value)); + } catch (IOException e) { + e.printStackTrace(); + } + binaryConsumer.moveWriterPosition(); + } + }, values); + } + + @Test + public void testConsumeInputStream() throws IOException { + testConsumeInputStream(new byte[][]{ + createBytes(DEFAULT_RECORD_BYTE_COUNT) + }, false); + + testConsumeInputStream(new byte[][]{ + createBytes(DEFAULT_RECORD_BYTE_COUNT), + createBytes(DEFAULT_RECORD_BYTE_COUNT) + }, false); + + testConsumeInputStream(new byte[][]{ + createBytes(DEFAULT_RECORD_BYTE_COUNT * 2), + createBytes(DEFAULT_RECORD_BYTE_COUNT), + createBytes(DEFAULT_RECORD_BYTE_COUNT) + }, false); + + testConsumeInputStream(new byte[][]{ + createBytes(INITIAL_VALUE_ALLOCATION * DEFAULT_RECORD_BYTE_COUNT) + }, false); + + testConsumeInputStream(new byte[][]{ + createBytes(INITIAL_VALUE_ALLOCATION * DEFAULT_RECORD_BYTE_COUNT * 10), + }, false); Review comment: According to the original logic, when a nullable consumer processes a null value, it just adds 1 to its own index and does not modify the content of the vector. And set the rowCount in ArrowVectorIterator. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
