kou commented on code in PR #45088:
URL: https://github.com/apache/arrow/pull/45088#discussion_r1894399115
##########
c_glib/test/parquet/test-arrow-file-writer.rb:
##########
@@ -89,10 +89,10 @@ def test_write_table
def test_write_chunked_array
schema = build_schema("enabled" => :boolean)
writer = Parquet::ArrowFileWriter.new(schema, @file.path)
- writer.new_row_group(2)
+ writer.new_row_group()
chunked_array = Arrow::ChunkedArray.new([build_boolean_array([true, nil])])
writer.write_chunked_array(chunked_array)
- writer.new_row_group(1)
+ writer.new_row_group()
Review Comment:
```suggestion
writer.new_row_group
```
##########
c_glib/test/parquet/test-arrow-file-writer.rb:
##########
@@ -89,10 +89,10 @@ def test_write_table
def test_write_chunked_array
schema = build_schema("enabled" => :boolean)
writer = Parquet::ArrowFileWriter.new(schema, @file.path)
- writer.new_row_group(2)
+ writer.new_row_group()
Review Comment:
Yes.
Could you omit `()` for no argument method call?
```suggestion
writer.new_row_group
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
