projjal commented on a change in pull request #9726:
URL: https://github.com/apache/arrow/pull/9726#discussion_r598375361
##########
File path: cpp/src/gandiva/function_registry_math_ops.cc
##########
@@ -59,6 +59,13 @@ std::vector<NativeFunction> GetMathOpsFunctionRegistry() {
BINARY_SAFE_NULL_NEVER_BOOL_FN(is_distinct_from, {}),
BINARY_SAFE_NULL_NEVER_BOOL_FN(is_not_distinct_from, {}),
+ // trigonometry functions
+ MATH_UNARY_OPS(sin, {}), MATH_UNARY_OPS(cos, {}), MATH_UNARY_OPS(asin,
{}),
+ MATH_UNARY_OPS(acos, {}), MATH_UNARY_OPS(tan, {}), MATH_UNARY_OPS(atan,
{}),
+ MATH_UNARY_OPS(sinh, {}), MATH_UNARY_OPS(cosh, {}), MATH_UNARY_OPS(tanh,
{}),
+ MATH_UNARY_OPS(cot, {}), MATH_UNARY_OPS(radians, {}),
MATH_UNARY_OPS(degrees, {}),
+ BINARY_SYMMETRIC_SAFE_NULL_IF_NULL(atan2, {}, float64),
Review comment:
atan should also be able to take other numeric types (int32, int64, and
float32) as arguments. Use MATH_BINARY_UNSAFE marcro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
