rluvaton opened a new pull request, #6922:
URL: https://github.com/apache/arrow-rs/pull/6922

   # Which issue does this PR close?
   
   N/A
   
   # Rationale for this change
    
   You can't build `BinaryDictionaryArray` from iterator of bytes  
   
   # What changes are included in this PR?
   
   added `from_iter` from iterator of `&[u8]` and from iterator of 
`Option<&[u8]>`
   
   # Are there any user-facing changes?
   
   Yes.
   
   **There are breaking changes**, see the failing example below with the fix:
   ```diff
   #[test]
   fn test_dictionary_all_string_nulls() {
   -   let test = vec![None, None, None];
   +   let test = vec![None::<&str>, None::<&str>, None::<&str>];
       let array: DictionaryArray<Int32Type> = test.into_iter().collect();
       array
           .into_data()
           .validate_full()
           .expect("All null array has valid array data");
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to