mapleFU commented on issue #45061:
URL: https://github.com/apache/arrow/issues/45061#issuecomment-2567602996
> As DictEncoder's method EstimatedDataEncdedSize don't count dictionary
size, the real buffered size is less than real situation.
Sorry for late reply:
```c++
inline int64_t dictionary_pagesize_limit() const { return
dictionary_pagesize_limit_; }
```
IMO:
1. dictionary size is controlled by `dictionary_pagesize_limit()`, it will
call `FallbackToPlain` when meeting the dictionary size to large
2. `EstimatedDataEncodedSize()` controls the
`ColumnWriterImpl::AddDataPage()`, which adds data page to a column. Dictionary
page is added after all "dict-encoded" data page is added
3. Some interface in `RowGroupWriter` can be used to add the dictionary size
for the global row-groups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
