wiedld commented on PR #6924: URL: https://github.com/apache/arrow-rs/pull/6924#issuecomment-2571377122
> Question. What does this provide which is missing with the current IntoIterator implementations for [&'a GenericByteArray](https://github.com/apache/arrow-rs/blob/b77d38d022079b106449ead3996f373edc906327/arrow-array/src/array/byte_array.rs#L547), [&'a FixedSizeBinaryArray](https://github.com/apache/arrow-rs/blob/b77d38d022079b106449ead3996f373edc906327/arrow-array/src/array/fixed_size_binary_array.rs#L651), and [&'a BinaryViewArray](https://github.com/apache/arrow-rs/blob/b77d38d022079b106449ead3996f373edc906327/arrow-array/src/array/byte_view_array.rs#L626)? My question above is because I think this may not be needed? But I wasn't sure if I was missing something. This introduced trait converts a referenced array to an ArrayIter, and it does so by abstracting over these three generic types (GenericBinaryArray, BinaryViewArray, FixedSizeBinaryArray) calling the `iter()`. When I looked at the existing code, we have a [&'a GenericByteArray](https://github.com/apache/arrow-rs/blob/b77d38d022079b106449ead3996f373edc906327/arrow-array/src/array/byte_array.rs#L547) which also takes a reference and returns ArrayIter. So I wasn't sure why this was needed -- and what it added by making the `iter()` trait which does the same thing as the existing `into_iter()` trait. Am I missing something? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
