kou commented on code in PR #45097:
URL: https://github.com/apache/arrow/pull/45097#discussion_r1906072528
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1777,13 +1777,28 @@ macro(build_thrift)
set(THRIFT_DEPENDENCIES ${THRIFT_DEPENDENCIES} boost_ep)
endif()
+ set(THRIFT_PATCH_COMMAND)
+ if(CMAKE_COMPILER_IS_GNUCC AND CMAKE_CXX_COMPILER_VERSION
VERSION_GREATER_EQUAL 15.0)
Review Comment:
If we always use `PATCH_COMMAND`, `patch` command is required in a build
machine. We want to avoid it. For example, `patch` command doesn't exist in
most Windows machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
