nevi-me commented on a change in pull request #9494: URL: https://github.com/apache/arrow/pull/9494#discussion_r598921015
########## File path: rust/datafusion-examples/Cargo.toml ########## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +[package] +name = "datafusion-examples" +description = "DataFusion usage examples" +version = "4.0.0-SNAPSHOT" +homepage = "https://github.com/apache/arrow"; +repository = "https://github.com/apache/arrow"; +authors = ["Apache Arrow <[email protected]>"] +license = "Apache-2.0" +keywords = [ "arrow", "query", "sql" ] +edition = "2018" + + +[dev-dependencies] +datafusion = { path = "../datafusion" } Review comment: This will break the publishing process as we're not pointing to versions, but paths. I think the default action should be not to publish this crate, so we need a `publish = false` line. ########## File path: rust/datafusion-examples/Cargo.toml ########## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +[package] +name = "datafusion-examples" Review comment: I'd lean on not publishing by default, so I'd prefer a `publish = false` on the Cargo file. I support clarifying this as part of ARROW-11863 @alamb. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
