lidavidm commented on code in PR #2401: URL: https://github.com/apache/arrow-adbc/pull/2401#discussion_r1909688535
########## java/driver/jni/src/main/java/org/apache/arrow/adbc/driver/jni/impl/NativeAdbcException.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.arrow.adbc.driver.jni.impl; + +/** + * Wrapper for a {@code struct AdbcException} that doesn't depend on other Java code. + * + * <p>This breaks a dependency chain in compilation. If we directly used AdbcException, then we + * would need to compile the Java code before compiling JNI code, but we need the compiled JNI code Review Comment: I can try to configure Maven to do this instead? It'd make the build a bit more complicated (run maven, then cmake, then maven) but maybe that's OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
