alamb commented on code in PR #6926:
URL: https://github.com/apache/arrow-rs/pull/6926#discussion_r1911203363
##########
arrow-array/src/array/fixed_size_binary_array.rs:
##########
@@ -59,6 +59,16 @@ pub struct FixedSizeBinaryArray {
}
impl FixedSizeBinaryArray {
+ /// Returns true if all data within this array is ASCII
+ pub fn is_ascii(&self) -> bool {
Review Comment:
I don't understand the need to check a binary array for ASCII -- there
shouldn't be any optimizations that rely on the data being ASCII
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]