returnString commented on a change in pull request #9762: URL: https://github.com/apache/arrow/pull/9762#discussion_r599049329
########## File path: rust/datafusion/src/catalog/schema.rs ########## @@ -0,0 +1,104 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! Describes the interface and built-in implementations of schemas, +//! representing collections of named tables. + +use crate::datasource::TableProvider; +use crate::error::{DataFusionError, Result}; +use std::any::Any; +use std::collections::HashMap; +use std::sync::{Arc, RwLock}; + +/// Represents a schema, comprising a number of named tables. +pub trait SchemaProvider: Sync + Send { + /// Returns the schema provider as [`Any`](std::any::Any) + /// so that it can be downcast to a specific implementation. + fn as_any(&self) -> &dyn Any; + + /// Retrieves the list of available table names in this schema. + fn table_names(&self) -> Vec<String>; + + /// Retrieves a specific table from the schema by name, provided it exists. + fn table(&self, name: &str) -> Option<Arc<dyn TableProvider>>; + + /// If supported by the implementation, adds a new table to this schema. + /// If a table of the same name existed before, it is replaced in the schema and returned. + #[allow(unused_variables)] + fn register_table( + &self, + name: String, + table: Arc<dyn TableProvider>, Review comment: The underscore method was my first approach here but I then discovered that it carried those symbols through to the docs as well (e.g. inline parameter names in vscode using rust analyser - presumably also the generated ones in docs.rs too? didn't test that bit) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
