mapleFU commented on code in PR #44043:
URL: https://github.com/apache/arrow/pull/44043#discussion_r1913040109
##########
cpp/src/parquet/metadata.cc:
##########
@@ -219,30 +219,29 @@ const std::string& ColumnCryptoMetaData::key_metadata()
const {
// ColumnChunk metadata
class ColumnChunkMetaData::ColumnChunkMetaDataImpl {
public:
- explicit ColumnChunkMetaDataImpl(const format::ColumnChunk* column,
- const ColumnDescriptor* descr,
- int16_t row_group_ordinal, int16_t
column_ordinal,
- const ReaderProperties& properties,
- const ApplicationVersion* writer_version,
- std::shared_ptr<InternalFileDecryptor>
file_decryptor)
+ explicit ColumnChunkMetaDataImpl(
+ const format::ColumnChunk* column, const ColumnDescriptor* descr,
+ int16_t row_group_ordinal, int16_t column_ordinal,
+ const ReaderProperties& properties, const ApplicationVersion*
writer_version,
+ const std::shared_ptr<InternalFileDecryptor>& file_decryptor)
: column_(column),
descr_(descr),
properties_(properties),
writer_version_(writer_version) {
column_metadata_ = &column->meta_data;
if (column->__isset.crypto_metadata) { // column metadata is encrypted
- format::ColumnCryptoMetaData ccmd = column->crypto_metadata;
+ const format::ColumnCryptoMetaData& ccmd = column->crypto_metadata;
if (ccmd.__isset.ENCRYPTION_WITH_COLUMN_KEY) {
if (file_decryptor != nullptr && file_decryptor->properties() !=
nullptr) {
// should decrypt metadata
std::shared_ptr<schema::ColumnPath> path =
std::make_shared<schema::ColumnPath>(
ccmd.ENCRYPTION_WITH_COLUMN_KEY.path_in_schema);
- std::string key_metadata =
ccmd.ENCRYPTION_WITH_COLUMN_KEY.key_metadata;
+ const std::string& key_metadata =
ccmd.ENCRYPTION_WITH_COLUMN_KEY.key_metadata;
Review Comment:
Also wonder should we check `row_group_ordinal >= 0` here? 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
