lidavidm commented on code in PR #524:
URL: https://github.com/apache/arrow-java/pull/524#discussion_r1917559794
##########
dev/release/release_rc.sh:
##########
@@ -105,23 +105,34 @@ if [ "${RELEASE_SIGN}" -gt 0 ]; then
echo "Found GitHub Actions workflow with ID: ${run_id}"
gh run watch --repo "${repository}" --exit-status "${run_id}"
- echo "Downloading .tar.gz from GitHub Releases"
+ echo "Downloading artifacts from GitHub Releases"
gh release download "${rc_tag}" \
- --dir . \
- --pattern "${tar_gz}" \
+ --dir "${artifacts_dir}" \
--repo "${repository}" \
--skip-existing
- echo "Signing tar.gz and creating checksums"
- gpg --armor --output "${tar_gz}.asc" --detach-sig "${tar_gz}"
+ echo "Signing artifacts"
+ rm -rf "${signed_artifacts_dir}"
+ mkdir -p "${signed_artifacts_dir}"
+ for artifact in "${artifacts_dir}"/*; do
+ case "${artifact}" in
+ *.asc | *.sha256 | *.sha512)
+ continue
+ ;;
+ esac
+ gpg --armor \
+ --detach-sig \
+ --output "${signed_artifacts_dir}/$(basename "${artifact}").asc" \
+ "${artifact}"
+ done
fi
if [ "${RELEASE_UPLOAD}" -gt 0 ]; then
echo "Uploading signature"
gh release upload "${rc_tag}" \
--clobber \
- --repo "${repository}" \
- "${tar_gz}.asc"
+ --repo "${repository:-kou/arrow-java}" \
Review Comment:
Should this default to apache/arrow-java?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
