birschick-bq commented on code in PR #2365:
URL: https://github.com/apache/arrow-adbc/pull/2365#discussion_r1924171371
##########
csharp/src/Drivers/Apache/Impala/ImpalaDatabase.cs:
##########
@@ -15,22 +15,29 @@
* limitations under the License.
*/
+using System;
using System.Collections.Generic;
+using System.Linq;
namespace Apache.Arrow.Adbc.Drivers.Apache.Impala
{
public class ImpalaDatabase : AdbcDatabase
{
readonly IReadOnlyDictionary<string, string> properties;
- internal ImpalaDatabase(IReadOnlyDictionary<string, string> properties)
+ public ImpalaDatabase(IReadOnlyDictionary<string, string> properties)
Review Comment:
Also changing all other AdbcDatabase implementations to use `internal`
access - to be consistent.
##########
csharp/src/Drivers/Apache/Impala/ImpalaDatabase.cs:
##########
@@ -15,22 +15,29 @@
* limitations under the License.
*/
+using System;
using System.Collections.Generic;
+using System.Linq;
namespace Apache.Arrow.Adbc.Drivers.Apache.Impala
{
public class ImpalaDatabase : AdbcDatabase
{
readonly IReadOnlyDictionary<string, string> properties;
- internal ImpalaDatabase(IReadOnlyDictionary<string, string> properties)
+ public ImpalaDatabase(IReadOnlyDictionary<string, string> properties)
Review Comment:
Also changing all other `AdbcDatabase` implementations to use `internal`
access - to be consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
