raulcd commented on code in PR #45326:
URL: https://github.com/apache/arrow/pull/45326#discussion_r1925679358
##########
cpp/cmake_modules/SetupCxxFlags.cmake:
##########
@@ -23,6 +23,12 @@ include(CheckCXXSourceCompiles)
message(STATUS "System processor: ${CMAKE_SYSTEM_PROCESSOR}")
+if(CMAKE_CXX_COMPILER_ID STREQUAL "AppleClang" OR CMAKE_CXX_COMPILER_ID
STREQUAL "Clang")
Review Comment:
but wouldn't the following catch that?
`if(NOT CMAKE_CXX_COMPILER_ID STREQUAL CMAKE_C_COMPILER_ID)`
Why only perform the check if the `CMAKE_CXX_COMPILER_ID` is clang?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
