Jefffrey commented on code in PR #7016:
URL: https://github.com/apache/arrow-rs/pull/7016#discussion_r1929198545
##########
arrow-buffer/src/builder/null.rs:
##########
@@ -54,7 +54,10 @@ pub struct NullBufferBuilder {
impl NullBufferBuilder {
/// Creates a new empty builder.
- /// `capacity` is the number of bits in the null buffer.
+ ///
+ /// Note that this method does not allocate any memory, regardless of the
+ /// `capacity` parameter. If an allocation is required, `capacity` is the
+ /// size in bits (not bytes) that will be allocated.
Review Comment:
```suggestion
/// Note that this method does not allocate any memory, regardless of the
/// `capacity` parameter. If an allocation is required, `capacity` is the
/// size in bits (not bytes) that will be allocated at minimum.
```
To take into account line 177 here:
https://github.com/apache/arrow-rs/blob/0c07ec79cd4b28e7aa9d15d1d58b5c5adafb6855/arrow-buffer/src/builder/null.rs#L174-L181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
