alamb commented on code in PR #6921:
URL: https://github.com/apache/arrow-rs/pull/6921#discussion_r1929251692
##########
parquet/src/arrow/array_reader/byte_view_array.rs:
##########
@@ -683,7 +685,7 @@ impl ByteViewArrayDecoderDelta {
/// Check that `val` is a valid UTF-8 sequence
pub fn check_valid_utf8(val: &[u8]) -> Result<()> {
- match std::str::from_utf8(val) {
+ match simdutf8::basic::from_utf8(val) {
Review Comment:
I think there is something wrong with how github is displaying this diff --
this callsite was changed to use simdutf8 in this PR
- https://github.com/apache/arrow-rs/pull/6668
The version on main doesn't have any calls to `from_utf8`:
https://github.com/apache/arrow-rs/blob/main/parquet/src/arrow/array_reader/byte_view_array.rs#L381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
