lidavidm commented on code in PR #2484:
URL: https://github.com/apache/arrow-adbc/pull/2484#discussion_r1931313487
##########
go/adbc/driver/snowflake/driver_test.go:
##########
@@ -2253,3 +2253,44 @@ func TestJSONUnmarshal(t *testing.T) {
}
}
}
+
+func (suite *SnowflakeTests) TestQueryTag() {
+ u, err := uuid.NewV7()
+ suite.Require().NoError(err)
+ tag := u.String()
+
suite.Require().NoError(suite.stmt.SetOption(driver.OptionStatementQueryTag,
tag))
+
+ val, err :=
suite.stmt.(adbc.GetSetOptions).GetOption(driver.OptionStatementQueryTag)
+ suite.Require().NoError(err)
+ suite.Require().Equal(tag, val)
+
+ suite.Require().NoError(suite.stmt.SetSqlQuery("SELECT 1"))
+ rdr, n, err := suite.stmt.ExecuteQuery(suite.ctx)
+ suite.Require().NoError(err)
+ defer rdr.Release()
Review Comment:
That _is_ the test: we query the query history with the tag and make sure it
comes back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
