raulcd commented on code in PR #44989:
URL: https://github.com/apache/arrow/pull/44989#discussion_r1934340981
##########
cpp/CMakeLists.txt:
##########
@@ -15,9 +15,14 @@
# specific language governing permissions and limitations
# under the License.
-cmake_minimum_required(VERSION 3.16)
+cmake_minimum_required(VERSION 3.25)
message(STATUS "Building using CMake version: ${CMAKE_VERSION}")
+# https://cmake.org/cmake/help/latest/policy/CMP0126.html
+#
+# set(CACHE) does not remove a normal variable of the same name.
Review Comment:
Yes, I added a comment on the PR that this can be tackled as a separate
issue. There is an issue with `ZLIB_LIBRARY` on Windows when using bundled ORC.
If we decide it's ok to merge and fix later, I'll open an issue to track it. I
was mainly waiting to find if @kou knew what could be the solution as I just
found out today :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
