hiroyuki-sato commented on code in PR #45417:
URL: https://github.com/apache/arrow/pull/45417#discussion_r1938824042
##########
.pre-commit-config.yaml:
##########
@@ -141,6 +141,18 @@ repos:
(
?^r/src/arrowExports\.cpp$|
)
+ - repo: https://github.com/rubocop/rubocop
+ rev: "v1.71.0"
+ hooks:
+ - id: rubocop
+ name: Ruby Format
+ alias: ruby-format
+ args: [--autocorrect]
+ exclude: >-
+ (
+ ?^dev/tasks/homebrew-formulae/.*\.rb$|
+ )
+ files: .*\.rb$
Review Comment:
Without this part and if the line width is 90, the pre-check claims the
following
As we discussed on this
https://github.com/apache/arrow/pull/45403#discussion_r1938219175,
we need to exclude homebrew formulae. So, I added this part.
```diff
diff --git a/dev/tasks/homebrew-formulae/apache-arrow.rb
b/dev/tasks/homebrew-formulae/apache-arrow.rb
index caf82b8db..01611d17b 100644
--- a/dev/tasks/homebrew-formulae/apache-arrow.rb
+++ b/dev/tasks/homebrew-formulae/apache-arrow.rb
@@ -110,7 +110,8 @@ class ApacheArrow < Formula
return 0;
}
EOS
- system ENV.cxx, "test.cpp", "-std=c++17", "-I#{include}", "-L#{lib}",
"-larrow", "-o", "test"
+ system ENV.cxx, "test.cpp", "-std=c++17", "-I#{include}", "-L#{lib}",
"-larrow",
+ "-o", "test"
system "./test"
end
end
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
