kou commented on code in PR #250: URL: https://github.com/apache/arrow-go/pull/250#discussion_r1940297248
########## ci/scripts/bench.sh: ########## @@ -0,0 +1,61 @@ +#!/usr/bin/env bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# this will output the benchmarks to STDOUT but if `-json` is passed +# as the second argument, it will create a file "bench_stats.json" +# in the directory this is called from containing a json representation + +set -ex + +# Validate input arguments +if [ -z "$1" ]; then + echo "Error: Missing source directory argument" + exit 1 +fi + +source_dir="$1" + +PARQUET_TEST_DATA="${source_dir}/cpp/submodules/parquet-testing/data" + +# If parquet_test_data doesn't exist, download it from Apache Arrow GitHub +if [ ! -d "$PARQUET_TEST_DATA" ]; then + echo "parquet_test_data not found. Fetching from Apache Arrow repository..." + mkdir -p "$PARQUET_TEST_DATA" + curl -L https://github.com/apache/parquet-testing/tree/master/data Review Comment: Hmm. We may not need this at all. How about the following? ```diff diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index a87eb9b..bc9b0fe 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -37,6 +37,8 @@ jobs: arch: ['amd64'] steps: - uses: actions/checkout@v4 + with: + submodules: recursive - name: Install dependencies run: | apt-get update diff --git a/ci/scripts/bench.sh b/ci/scripts/bench.sh old mode 100644 new mode 100755 index 3be7829..597b2a1 --- a/ci/scripts/bench.sh +++ b/ci/scripts/bench.sh @@ -31,15 +31,7 @@ fi source_dir="$1" -PARQUET_TEST_DATA="${source_dir}/cpp/submodules/parquet-testing/data" - -# If parquet_test_data doesn't exist, download it from Apache Arrow GitHub -if [ ! -d "$PARQUET_TEST_DATA" ]; then - echo "parquet_test_data not found. Fetching from Apache Arrow repository..." - mkdir -p "$PARQUET_TEST_DATA" - curl -L https://github.com/apache/parquet-testing/tree/master/data -fi - +PARQUET_TEST_DATA="${source_dir}/parquet-testing/data" export PARQUET_TEST_DATA pushd "${source_dir}" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
