raulcd commented on code in PR #44989:
URL: https://github.com/apache/arrow/pull/44989#discussion_r1943284927
##########
dev/tasks/linux-packages/apache-arrow/apt/ubuntu-focal/Dockerfile:
##########
@@ -79,3 +80,9 @@ RUN \
ln -fs /usr/local/bin/gi-docgen /usr/bin && \
apt clean && \
rm -rf /var/lib/apt/lists/*
+
+ARG cmake=3.25.0
+RUN curl -L \
Review Comment:
Once I merged the above I found that debhelper still expects the cmake
build-system on the path, which doesn't seem to be available on /usr/local/bin.
After some testing I added the following to the
`dev/tasks/linux-packages/apache-arrow/debian/rules` which was able to find
cmake:
```bash
if [ "$${code_name}" = "focal" ] || [ "$${code_name}" = "jammy" ]; then \
ln -sf /usr/local/bin/cmake /usr/bin/cmake; \
fi; \
```
We are basically creating the same link we were creating on the Dockerfile
but on the Debian rules. I haven't been able to find any other way otherwise we
start getting:
```
cd cpp_build && cmake -DCMAKE_INSTALL_PREFIX=/usr
-DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_SYSCONFDIR=/etc
-DCMAKE_INSTALL_LOCALSTATEDIR=/var -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON
-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_RUNSTATEDIR=/run
-GNinja -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_AUTOGEN_VERBOSE=ON
-DCMAKE_INSTALL_LIBDIR=lib/x86_64-linux-gnu -DARROW_AZURE=OFF
-DARROW_BUILD_UTILITIES=ON -DARROW_COMPUTE=ON -DARROW_CSV=ON -DARROW_CUDA=ON
-DARROW_DATASET=ON -DARROW_FILESYSTEM=ON -DARROW_FLIGHT=ON
-DARROW_FLIGHT_SQL=ON -DARROW_GANDIVA=ON -DARROW_GCS=ON -DARROW_HDFS=ON
-DARROW_JSON=ON -DARROW_MIMALLOC=ON -DARROW_ORC=ON -DARROW_PACKAGE_KIND=deb
-DARROW_PARQUET=ON -DARROW_S3=ON -DARROW_USE_CCACHE=OFF -DARROW_USE_MOLD=ON
-DARROW_WITH_BROTLI=ON -DARROW_WITH_BZ2=ON -DARROW_WITH_LZ4=ON
-DARROW_WITH_SNAPPY=ON -DARROW_WITH_ZLIB=ON -DARROW_WITH_ZSTD=ON
-DCMAKE_BUILD_TYPE=release -DCUDAToolkit_ROOT=/usr
-DFETCHCONTENT_FULLY_DISCONNECTED=OFF -DPARQUET_BUILD_EXECUTABLES=ON -DPAR
QUET_REQUIRE_ENCRYPTION=ON ../cpp
Can't exec "cmake": No such file or directory at
/usr/share/perl5/Debian/Debhelper/Dh_Lib.pm line 484.
dh_auto_configure: error: cd cpp_build && cmake -DCMAKE_INSTALL_PREFIX=/usr
-DCMAKE_BUILD_TYPE=None -DCMAKE_INSTALL_SYSCONFDIR=/etc
-DCMAKE_INSTALL_LOCALSTATEDIR=/var -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON
-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_RUNSTATEDIR=/run
-GNinja -DCMAKE_VERBOSE_MAKEFILE=ON -DCMAKE_AUTOGEN_VERBOSE=ON
-DCMAKE_INSTALL_LIBDIR=lib/x86_64-linux-gnu -DARROW_AZURE=OFF
-DARROW_BUILD_UTILITIES=ON -DARROW_COMPUTE=ON -DARROW_CSV=ON -DARROW_CUDA=ON
-DARROW_DATASET=ON -DARROW_FILESYSTEM=ON -DARROW_FLIGHT=ON
-DARROW_FLIGHT_SQL=ON -DARROW_GANDIVA=ON -DARROW_GCS=ON -DARROW_HDFS=ON
-DARROW_JSON=ON -DARROW_MIMALLOC=ON -DARROW_ORC=ON -DARROW_PACKAGE_KIND=deb
-DARROW_PARQUET=ON -DARROW_S3=ON -DARROW_USE_CCACHE=OFF -DARROW_USE_MOLD=ON
-DARROW_WITH_BROTLI=ON -DARROW_WITH_BZ2=ON -DARROW_WITH_LZ4=ON
-DARROW_WITH_SNAPPY=ON -DARROW_WITH_ZLIB=ON -DARROW_WITH_ZSTD=ON
-DCMAKE_BUILD_TYPE=release -DCUDAToolkit_ROOT=/usr
-DFETCHCONTENT_FULLY_DISCONNECTED=OFF -DPARQUET_B
UILD_EXECUTABLES=ON -DPARQUET_REQUIRE_ENCRYPTION=ON ../cpp failed to execute:
No child processes
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
